gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/8] Use posix_spawn to run external scripts


From: Pawel Kot
Subject: Re: [PATCH 7/8] Use posix_spawn to run external scripts
Date: Mon, 3 Dec 2018 20:12:44 +0300

Hi,

On Mon, Dec 3, 2018 at 7:50 PM Ladislav Michl <address@hidden> wrote:
> Sure, no problem. I read above you are fine with that approach in general.

Yes, overall it seems fine to me.

> However it would be nice if someone could actually give pachset a try.
> Preferably on non linux platforms.

I will on Windows and OS X once I'm done with travelling.

> > > -typedef void (*cfg_foreach_func)(const char *section, const char *key,
> > const char *value);
> > > -void cfg_foreach(const char *section, cfg_foreach_func func);
> > > +#define cfg_foreach_entry(section, header, entry) \
> > > +       for (; header != NULL; header = header->next) \
> > > +               if (strcmp(section, h->section) == 0) \
> > > +                       for (entry = h->entries; entry != NULL; entry =
> > entry->next)
> >
> > Why that?
>
> If that question leads to opencoding that single macro use, I'm fine
> with that.

Yes, that's what I've meant. Sorry for not being clear.

Cheers,
Paweł
--
Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]