Re: [Gnu-arch-users] Re: reminder: winning smallish project

[Robert Collins]

On Sat, 2003-09-20 at 16:55, Miles Bader wrote:

> It may sound silly, but it's not.  It's like bookkeeping -- you never
> want to delete history, so you can't erase the record that you made a
> mistake, but you can correct the mistake, by adding a correction entry.
> In that case, the mistaken entry probably doesn't correspond to any
> real world event -- it's a mistake -- but there's a record of it.

leaving the patch log behind indicates that the -merge-or-commit was not
a mistake. It was deliberate, you want to prevent the relevant changes
ever being reinstated. Correcting the code - fixing a bug by doing the
opposite change is what you indicate by leaving the log behind.

> If you're correcting a mistaken changeset, you want to do the same
> thing.  The normal act of replay --reverse is a funnier operation
> (even if the implementation is more straightforward).

replay --reverse is what you use to indicate a mistake, by backing out
the change. There is a full record that you had made the change and then
reversed it.

I suspect you don't quite grok patchlogs yet.

Rob
-- 
GPG key available at: <http://members.aardvark.net.au/lifeless/keys.txt>.

signature.asc
Description: This is a digitally signed message part