gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] checksum files -- off by one error


From: Tom Lord
Subject: Re: [Gnu-arch-users] checksum files -- off by one error
Date: Wed, 24 Dec 2003 18:38:25 -0800 (PST)

    > From: Johannes Berg <address@hidden>

    > I just noticed a small off-by-one error in ./libarch/archive-pfs.c, line
    > 1808:
    >   md5x[33] =3D 0;
    > really should be
    >   md5x[32] =3D 0;
    > (because bytes 0..31 are filled with the hex md5sum, and byte 33 isn't
    > even in that array!)


Man, that was fast.  Thanks.  Fixed and pushed within the hour after
sending this.

(Note that the GPG and MD5 stuff is slightly midstream still.  (but,
this bug aside :-), seemingly safe to try out for people tracking the
head revision)).

-t




reply via email to

[Prev in Thread] Current Thread [Next in Thread]