gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnu-arch-users] Re: [PATCH] arch speedups on big trees


From: Miles Bader
Subject: [Gnu-arch-users] Re: [PATCH] arch speedups on big trees
Date: 08 Jan 2004 11:28:32 +0900

Chris Mason <address@hidden> writes:
> > That part is actually easy.  arch_make_changeset creates the tmpfile,
> > but could instead push that responsibility to arch_invoke_diff.  It
> > would only be created/unlinked if the diff func reported changes.
> 
> Once the suse internal mirror gets going, you can grab
> ftp.suse.com/pub/people/mason/patches/arch/arch-faster-7.diff.gz

This doesn't apply to the default sources -- which seems to call
arch_invoke_diff on every file in the tree anyway.

Actually, it also won't fix the case I mentioned.  Basically I'd like to
see the temporary output file avoided _even when diff is invoked_ (which
is all too often with the current tla); obvious invoking diff and
reading the files unnecessarily is a lose, but the number of NFS rpcs
could maybe be halved by not using an output tmp file, and
directory-modifying and creation operations seems unusually pokey.

Here's some packet dumps:

Non-NFS output file, `diff -u ,x ,y > /tmp/,tmp':

Attachment: nfs-null-diff.trace
Description: NFS packet dump for `diff -u ,x ,y > /tmp/,tmp'


NFS output file, `rm -f ,tmp2; diff -u ,s ,t > ,tmp2; rm ,tmp2':

Attachment: nfs-tmp-diff.trace
Description: NFS packet dump for `rm -f ,tmp2; diff -u ,s ,t > ,tmp2; rm ,tmp2'



-Miles
-- 
"1971 pickup truck; will trade for guns"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]