Re: [Gnu-arch-users] Re: [PATCH] arch speedups on big trees

[Chris Mason]

On Thu, 2004-01-08 at 16:55, Aaron Bentley wrote:
> On Thu, 2004-01-08 at 09:27, Chris Mason wrote:
> > 
> > So as soon as the diff program makes output, we open the tmp file?
> > 
> > Because of arch_binary_files_differ(), we are 100% sure diff is going to
> > have output.  So just open the tmp file to start with and make life easy
> > ;)
> 
> Sure, but most tools can accept data on stdin, so in theory you don't
> even need a tmp file.  Or are we using some utility that won't play
> ball?

One primary purpose for taking the diffs is making changesets, where we
actually want the diff output in file form for storing in the changeset
dir.  It makes more sense to me to avoid creating the temp file unless
you actually need it, mostly because it is a small change that covers
the most common case.

-chris