[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnu-arch-users] some questions and problems
From: |
Johannes Berg |
Subject: |
[Gnu-arch-users] some questions and problems |
Date: |
Sun, 18 Jan 2004 16:55:04 +0100 |
Hi,
In the past few days I've dissected a lot of tla/hackerlab/build-tools
code and found some things I wanted to ask:
* /tmp is hardcoded in a lot of places, shouldn't $TMPDIR be used
instead? (sort of like the logic mktemp -t uses)
* whats the difference between
here_fd = safe_open (".", O_RDONLY, 0);
and
here_dir = safe_current_working_directory ();
and using safe_fchdir vs. safe_chdir etc? Is the only
difference less memory usage?
* why doesn't tla ever call vfdbuf_flush_all()? What guarantees that
all vfdbuf descriptors are flushed (for example in tla rbrowse)? (I
think I'm just missing something here)
* arch_default_naming_conventions_regexp says:
case arch_inventory_excludes:
{
return str_save (0, "^(.arch-ids|\\{arch\\}|\\.arch-inventory)$");
}
shouldn't that be
return str_save (0, "^(\\.arch-ids|\\{arch\\}|\\.arch-inventory)$");
?
* similarly in arch_ancient_default_naming_conventions_regexp and
arch_null_default_naming_conventions_regexp
johannes
--
http://www.sipsolutions.de/
GnuPG key: http://www.sipsolutions.de/keys/JohannesBerg.asc
Key-ID: 9AB78CA5 Johannes Berg <address@hidden>
Fingerprint = AD02 0176 4E29 C137 1DF6 08D2 FC44 CF86 9AB7 8CA5
signature.asc
Description: This is a digitally signed message part
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Gnu-arch-users] some questions and problems,
Johannes Berg <=