[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnu-arch-users] [MERGE REQUEST] use a global version_string accross tla
From: |
Yann Droneaud |
Subject: |
[Gnu-arch-users] [MERGE REQUEST] use a global version_string accross tla commands |
Date: |
Tue, 31 Aug 2004 00:58:45 +0200 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
address@hidden/tla--libarch-version-str--1.3--patch-1
address@hidden/tla--libarch-version-str--1.3--patch-2
Location:
http://sherkan.tuxfamily.net/~meuh/arch/address@hidden/
Mirrored at:
http://mirrors.sourcecontrol.net/address@hidden/
Archzoom:
http://sherkan.tuxfamily.net/~arch/archzoom.cgi/address@hidden/tla--libarch-version-str--1.3
> Hi,
>
> I found that the 'version_string' is duplicated accross almost every
> source files correspondig to a command.
>
> $ find tla-1.3/src/tla/libarch/ -name 'cmd*.c' | wc -l
> 100
>
> $ strings /home/meuh/bin/tla | grep -c 'from regexps\.com'
> 97
>
> $ grep 'char.*version_string' tla-1.3/src/tla/libarch/* | wc -l
> 97
>
> This is many bytes wasted in the binary to store redundant information,
> so we could add a version.c file holding only one defintion of the
> version string.
>
> Should I do it (it's something i can easily contribute to tla), or
> someone had already done the job ?
>
Job done: only one global version_string.
Created two new files: tla/libarch/version.[ch]
Removed other version_string definitions.
People could be unhappy with the copyright in the version string
and copyrights on the new files (i'm ok to change them if requested).
Regards
--
Yann Droneaud (aka Meuh) <address@hidden>
http://meuh.org/ | http://sherkan.tuxfamily.net/~meuh/
Une vache perdue sur Internet | A cow lost in the Internet
1024D/BEA43321 5D91 B5B0 5137 B8FE 6882 FE19 CAA0 6F05 BEA4 3321