gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] [BUG] mini patch for pfs-dav.c and libneon GNU TLS


From: Matthew Dempsky
Subject: Re: [Gnu-arch-users] [BUG] mini patch for pfs-dav.c and libneon GNU TLS work
Date: Sun, 26 Sep 2004 02:18:58 -0500
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

John Meinel <address@hidden> writes:

>>
>>
>>>-  answer->dav_port = 80;
>>>+  if (!str_cmp(answer->dav_scheme, "http"))
>>>+      answer->dav_port = 80;
>>>+  else
>>>+      answer->dav_port = 443;
>>
>
> Just a quick question. Shouldn't this be:
>
> if (!str_cmp (answer->dav_scheme, "https"))
>       answer->dav_port = 443;
> else:
>       answer->dav_port = 80;
>
> Meaning, default to 80, unless we are sure this should be 443. The way
> the patch was submitted states "default to 443" unless we know we
> should be on 80.
>
> I don't know for sure. But I would say, given any port to pick as
> default, go with 80.
>
> I don't know what strings would exist in dav_scheme, though, to really
> recommend a specific fix.

pfs-dav.c only intercepts http:// and https:// schemes from what I can
tell in the source, so either the original or this are equivalent.  (I
was originally going to comment on the same thing, but figured "http"
is 1 byte less to compare than "https". ;-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]