Re: [Gnu-arch-users] [MERGE REQUEST] fix bug 100 (having fifos, sockets etc in the tree)

[Matthew Dempsky]

Johannes Berg <address@hidden> writes:

> Base-Revision: address@hidden/tla--devo--1.2--patch-25
> Revision: address@hidden/tla--bug-100--1.2--patch-1
> Bug: 100
>
> For review and because it is so short, here's the patch:

Donning my hat as official Chief Assistant in charge of Ensuring
Coding Style Integrity (not really, but it's a catchy title) ...

> --- orig/libarch/invent.c
> +++ mod/libarch/invent.c
> @@ -584,7 +584,16 @@
>          }
>
>        safe_lstat (rel_file, &stat_buf);
> -
> +
> +      /* only symlinks, directories and plain files are
> +       * considerably source, all others need to be precious
> +       */
> +      if ( !S_ISREG(stat_buf.st_mode) &&
> +           !S_ISLNK(stat_buf.st_mode) &&
> +           !S_ISDIR(stat_buf.st_mode) )
> +        {
> +          goto precious_file;
> +        }

Try this instead:

    if (   !S_ISREG (stat_buf.st_mode)
        && !S_ISLNK (stat_buf.st_mode)
        && !S_ISDIR (stat_buf.st_mode))
      {
        goto precious_file;
      }