[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnu-arch-users] Having two precommit hooks

From: Mikhael Goikhman
Subject: [Gnu-arch-users] Having two precommit hooks
Date: Sat, 9 Oct 2004 16:37:30 +0000
User-agent: Mutt/

On 09 Oct 2004 16:03:45 +1000, Erik de Castro Lopo wrote:
> On Sat, 09 Oct 2004 15:53:52 +1000
> Robert Collins <address@hidden> wrote:
> > The precommit hook is deliberately post-changeset creation. It is
> > intended for regression tests or other such things to be run, i.e. code
> > format checkers.... not code reformatters.
> As the person who added the precommit hook feature, i can confirm
> that this was the intention.

Like others, I thought "precommit" suggests the tree may be modified.
If we are going to have two precommit hooks, then I suggest to use
intuitive names this time, i.e. prepare-commit and confirm-commit hooks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]