Re: [Gnu-arch-users] Re: patch: clean up some cacherev mess

[Mikhael Goikhman]

On 19 Nov 2005 12:50:12 +0100, Matthieu Moy wrote:
> 
> Derek Zhou <address@hidden> writes:
> 
> > --- orig/libarch/archive-cache.c
> > +++ mod/libarch/archive-cache.c
> > @@ -27,7 +27,7 @@
> >    t_uchar * tmp_dir = 0;
> >    t_uchar * pristine_dir = 0;
> >  
> > -  tmp_dir = tmp_file_name (".", ",,archive-cache-revision");
> > +  tmp_dir = tmp_file_name ("/tmp", ",,archive-cache-revision");
> >    pristine_dir = file_name_in_vicinity (0, tmp_dir, revision);
> >  
> >    safe_mkdir (tmp_dir, 0777);
> 
> "/tmp/" should be something like tmp_dir(...) (with the appropriate
> "free") to obey TMPDIR.

Please don't blindly change "." to "/tmp" if this has a side effect of
loosing inherited g+s permission bit (and group name) in non-transient
subdirectories created by tla.

Regards,
Mikhael.