[GNU Crypto] DH problem

[Casey Marshall]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I think the Diffie Hellman key agreement has a bug in it -- the
`while' where the random key is generated looks like its condition is
the opposite. That is, it should be an "until this is true" not "while
this is true". Am I correct here?

At any rate, with it negated the algorithm doesn't hang forever.

Also, a suggestion: allow the PRNG parameter to be either a
SecureRandom *or* an IRandom.

- -- 
Casey Marshall || address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.7 <http://mailcrypt.sourceforge.net/>

iD8DBQE/6ik/gAuWMgRGsWsRAtduAJ9sU9JNbldx10yqNg1ak0EPDohJVACcDscx
qQ4SYEAUu0crn9jP8oBcgp0=
=1DGG
-----END PGP SIGNATURE-----

dh.patch
Description: Text Data