[gnuastro-commits] master fcfc04f: Typo in warp application

[Mohammad Akhlaghi]

branch: master
commit fcfc04f12dfe3c2b6d9a623641e98f18edc7df9e
Author: Vladimir Markelov <address@hidden>
Commit: Mohammad Akhlaghi <address@hidden>

    Typo in warp application
    
    When checking for the direction of the second dimension to set the
    alignment matrix in Warp, both branches of the ternary operation returned
    the same value. But according to the comments and the code above one of the
    two value is negative.
    
    This fixes bug #51536.
---
 NEWS          | 2 ++
 bin/warp/ui.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index fc5a907..3304cc3 100644
--- a/NEWS
+++ b/NEWS
@@ -107,6 +107,8 @@ GNU Astronomy Utilities NEWS                          -*- 
outline -*-
 
   Crashes on 32-bit and big-endian systems (bug #51476).
 
+  Warp's align matrix when second dimention must be reversed (bug #51536).
+
   Reading BZERO for unsigned 64-bit integers (bug #51555).
 
   Arithmetic with one file and no operators (bug #51559).
diff --git a/bin/warp/ui.c b/bin/warp/ui.c
index 5000605..94f5662 100644
--- a/bin/warp/ui.c
+++ b/bin/warp/ui.c
@@ -518,7 +518,7 @@ ui_matrix_make_align(struct warpparams *p, double *tmatrix)
       x[0] = w[0]<0 ? 1.0f : -1.0f;  /* Has to be negative. */
       x[1] = 0.0f;
       x[2] = 0.0f;
-      x[3] = w[3]>0 ? 1.0f : 1.0f;   /* Has to be positive. */
+      x[3] = w[3]>0 ? 1.0f : -1.0f;  /* Has to be positive. */
     }
   else
     {