gnuastro-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[task #16126] astscript-radial-profile: including the --azimuth option


From: Mohammad Akhlaghi
Subject: [task #16126] astscript-radial-profile: including the --azimuth option
Date: Fri, 18 Feb 2022 07:36:03 -0500 (EST)

Update of task #16126 (project gnuastro):

                  Status:                    Done => In Progress            
        Percent Complete:                    100% => 90%                    

    _______________________________________________________

Follow-up Comment #1:

This is great Raul, thanks a lot ;-).

Sepideh found a bug in the radial profile script that she has Committed here
<https://gitlab.com/Sepideh.Esk/gnuastro/-/commit/7c065b720596>. Can you also
check and rebase that commit over this branch, so I merge them in together?

The reason I am suggesting this is that in line 560 of your additions
<https://gitlab.com/infantesainz/gnuastro/-/blob/3365df59f3c3eaeeb778dbc6d2eb8f5973f598cb/bin/script/radial-profile.in#L560>,
I don't see how you have accounted for the situation where no '--azimuth' is
called.

In the other steps (for example the undersampling part
<https://gitlab.com/infantesainz/gnuastro/-/blob/3365df59f3c3eaeeb778dbc6d2eb8f5973f598cb/bin/script/radial-profile.in#L598>),
when that operation is not called by the user, we make a symbolic link to the
output file of that step with a fixed name. So its good to follow the same
convention for the azimuthal part also.

That is why I recommended to take a look at Sepideh's commit also (on properly
dealing with symbolic links).

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/task/?16126>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]