Re: [gnugo-devel] Arraybound violation in 3.1.16

[Daniel Bump]

Teun wrote:

> This patch adds an assertion for an array boundviolation.
> This assertion is triggered when running

Apparently this is what was intended (see patch, untested).

I've found a way of triggering a crash in atari_atari_confirm_safety.
More about that later.

Dan

Index: engine/reading.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/reading.c,v
retrieving revision 1.38
diff -u -r1.38 reading.c
--- engine/reading.c    10 Dec 2001 17:22:40 -0000      1.38
+++ engine/reading.c    12 Dec 2001 17:04:41 -0000
@@ -895,12 +895,10 @@
 
        for (r = -1; r < max_points; r++) {
          /* -1 is used only when stackp > 0. */
-         if (stackp > 0) {
-           if (r == -1)
-             bb = dd;
-           else
-             break;
-         }
+         if (r == -1 && stackp > 0)
+           break;
+         if (r == -1)
+           bb = dd;
          else {
            if (worm[adjs[k]].defend_codes[r] == 0)
              break;