nando_3_15.3a (was RE: [gnugo-devel] small revision in find_more_ owl_attack_and_defe nse_moves())

[Portela Fernand]

Well, sorry for the noise I generated yesterday. I'm not very familiar with
the semeai code (and still won't be for a while I think) and didn't realize
that the tests that I've submitted are simply related to this topic. So,
thanks to Gunnar, an even better patch follows.

Supercedes nando_3_15.3

Regression breakage : 7 PASSes and 5 FAILs

(where uncommented, the pass is judged good)

lazarus:14    PASS  GG now prefers T5, good.
strategy2:54  PASS
strategy2:75  FAIL  (see comment in previous post)
strategy2:76  FAIL  (same)
nngs:290      FAIL  passes with --semeai-variations 300
nngs:380      FAIL  the only problematic case...
global:3      PASS  wow, impressive position
13x13:61      FAIL  passes with --semeai-variations 300
nngs3:1190    PASS  
nngs4:220     PASS  Unless I'm missing something again, I can't say that
                    I like P8 much more than T2
tactics1:105  pass
tactics1:106  pass

Owl nodes : +0.2%

A short comment : loosing or winning semeais may (and often do) have very
large repercussions. Limiting ourselves to 250 nodes looks a bit too few to
me.

/nando

- small inconsistency corrected in owl semeai code
- small change in find_more_owl_attack_and_defense_moves()


Index: engine/owl.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/owl.c,v
retrieving revision 1.136
diff -u -r1.136 owl.c
--- engine/owl.c        5 Jan 2003 15:49:15 -0000       1.136
+++ engine/owl.c        10 Jan 2003 08:08:21 -0000
@@ -635,7 +635,8 @@
        READ_RETURN_SEMEAI(read_result, move, PASS_MOVE, ALIVE, ALIVE);
       }
     }
-    if (min_eyes(&probable_eyes_b) >= 2 || owl_escape_route(owlb) >= 5) {
+    if (min_eyes(&probable_eyes_b) >= 2
+       || (stackp > 2 && owl_escape_route(owlb) >= 5)) {
       /* you are alive */
       if (max_eyes(&probable_eyes_a) < 2) {
        /* I am dead */
Index: engine/value_moves.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/value_moves.c,v
retrieving revision 1.76
diff -u -r1.76 value_moves.c
--- engine/value_moves.c        2 Jan 2003 00:23:29 -0000       1.76
+++ engine/value_moves.c        10 Jan 2003 08:08:24 -0000
@@ -398,7 +398,7 @@
   for (pos = BOARDMIN; pos < BOARDMAX; pos++) {
     if (IS_STONE(board[pos])
        && dragon[pos].origin == pos
-       && dragon[pos].owl_status == CRITICAL) {
+       && dragon[pos].status == CRITICAL) {
       for (pos2 = BOARDMIN; pos2 < BOARDMAX; pos2++) {
        if (board[pos2] != EMPTY)
          continue;