Re: [gnugo-devel] unsigned bug in semeai code

[bump]

Arend wrote:

> This seems to be a serious bug in do_owl_analyze_semeai to me:
> 
>     /* FIXME: This is kind of quick and dirty. */
>     probable_eyes_a.b -= matches_found;
> 
> proable_eyes_a.b is an unsigned char.

You deleted a line. The actual statement is:

      /* FIXME: This is kind of quick and dirty. */
      if (probable_eyes_a.b > matches_found)
        probable_eyes_a.b -= matches_found;
      else probable_eyes_a.b = 0;

This will never decrement probable_eyes_a.b below zero.

So why is there a problem?

Dan