Re: [gnugo-devel] unsigned bug in semeai code

[Gunnar Farneback]

Arend wrote:
> This seems to be a serious bug in do_owl_analyze_semeai to me:
> 
>     /* FIXME: This is kind of quick and dirty. */
>     probable_eyes_a.b -= matches_found;
> 
> proable_eyes_a.b is an unsigned char.
> 
> (Haven't checked the effects of fixing this yet.)

Quick, dirty, and buggy. But it has been fixed recently in the main
branch (you are apparently looking in the SPEC branch). Now only quick
and dirty are left (hopefully).

> Curiously, this is also almost the only time that the struct eyevalue is
> directly accessed outside the helper functions in optics.c designed to
> do this (set_eyevalue() and friends).

That's the dirty part. I'm certain there's a better way to handle the
eyespace estimates in the semeai code, but I didn't want to let that
hold up the conversion to the current eyespace value paradigm.

/Gunnar