Re: [gnugo-devel] resign_3_17.1

[Arend Bayer]

Dan wrote:

> > > I've put up a patch called resign_3_17.1 which fixes
> > > some warnings from nando_3_17.1.
> >
> > I had just put a patch together to fix this differently. IMO, all the
> > gtp_...() functions in play_gtp.c should have "const char *s" as
> > argument. That's how they are used (except in play_black() and
> > play_white()), and gtp.c shouldn't have to worry about the command
> > string possibly getting changed on the callback.
>
> How does your patch fix this?

Well, you meant the
"call to gtp_echo discards const from qualifier type", no?
Changing all gtp_...() functions (including gtp_echo) to have (const char *)
as argument of course fixes this.

But I have no strong opinions on this one.

ARend