Re: [gnugo-devel] how to patch regress 13x13:6

[Paul Pogonyshev]

kevin wrote:
>  --- Evan Berggren Daniel <address@hidden>
> wrote: > Any chance you have patches for 13x13b:6 or
> > 13x13b:8?
> ...
>
>   originally, D301 looks like:
> ...

when Evan was speaking of patches, he meant those funny things with
pluses and minuses in the first column. to make them you'll need a
`diff' program. the best (since it has many more advantages) way
to get one is to install a unix-like system, e.g. gnu/linux or
freebsd (if i remember correctly you are using windows). another
option would be to install an emulator of such a system, e.g.
cygwin. finally, there are some cvs clients for windows out there
(i used to use wincvs before i switched to gnu/linux). they all
must come with a `diff'.

>   then, i try to just add:
>
>
>
> Pattern D301
>
> X..?
> O.*.
> O..?
>
> :8,E,value(80)
>
> X..?
> B.*a
> B..?
>
> ;!oplay_attack(*,B)
>
> X..?
> O.*a
> O..?
>
> ;owl_escape_value(a) > 1
>
>   and compiler reports error.

just use plain c syntax, that is:

; owl_escape_value(a) > 1 && !oplay_attack(*,B)

`mkpat' can't join several separate constraints into one. besides,
using `&&' and others saves a lot of space in .db files and improves
pattern readability and maintainability.

>   so, i comment out the old constraint:
> ...
>
>   compile ok. but when i run it, D301 still matched
> with B3 for B5. i m not sure i have followed your
> instructions correctly.

so you should have written the old and the new constraint together
joining them with and operator. and don't forget to place
owl_escape_value() first since it is way much faster to check.

>   i appreciate your help and like to hear more
> suggestions from you.

your next step would be to check if the combined constraint works
and if it does, to send us a patch. you can do without patches for
a while (e.g. by writing "change this line to that"), but if you
want to work with gnu go seriously then sending your changes in the
form of patches is a must.

Paul