Re: [gnugo-devel] Gunnar's patch

[bump]

Gunnar has proposed keeping the owl phase on for the entire
semeai reading, on the grounds that turning it off is a
premature optimization.

It occurred to me that there is a definite bug in that
the owl phase should definitely not be turned off
until there are no owl moves for either player. I
therefore tried changing the code that turns off the
owl phase as follows:

    /* If no owl moves were found on two consecutive moves, 
       turn off the owl phase */
    if (moves[0].pos == NO_MOVE) {
      if (owl_phase == 1)
        owl_phase = 2;
      else if (owl_phase == 2)
        owl_phase = 0;
    }
    else owl_phase = 1;

Apart from this, everything is as in Gunnar's patch.
This is a little faster, though not as much as I had
hoped, and gives a net gain of 8 PASS, whereas Gunnar's
patch gives a net gain of 10.

Here are some timings:

                                          Time           Delta

Current CVS                               8419             0+
Gunnar's patch                            8799            10+
Patched but keeping tactical phase        8562             6+
Gunnar's patch as modified above          8702             8+

Dan

Results for Gunnar's patch with the above modification:

./regress.sh . owl.tst 
260 unexpected PASS!
./regress.sh . trevora.tst 
480 unexpected FAIL: Correct 'E4', got 'F5'
./regress.sh . nngs1.tst 
32 unexpected FAIL: Correct 'L12|K16|H16', got 'E5'
./regress.sh . neurogo.tst 
11 unexpected PASS!
14 unexpected FAIL: Correct 'Q4', got 'M8'
./regress.sh . arion.tst 
6 unexpected FAIL: Correct 'E19|F19|F18', got 'G19'
./regress.sh . viking.tst 
3 unexpected PASS!
./regress.sh . lazarus.tst 
4 unexpected FAIL: Correct 'R12|Q12|M8', got 'S10'
9 unexpected FAIL: Correct 'D15|F15', got 'S12'
15 unexpected FAIL: Correct 'Q15|T5|H5|H3', got 'S13'
./regress.sh . trevorb.tst 
100 unexpected PASS!
820 unexpected PASS!
./regress.sh . strategy2.tst 
80 unexpected PASS!
./regress.sh . nicklas5.tst 
1212 unexpected FAIL: Correct 'dead', got 'alive'
./regress.sh . nngs.tst 
820 unexpected FAIL: Correct 'J13|L9', got 'C15'
1020 unexpected PASS!
./regress.sh . trevorc.tst 
1440 unexpected PASS!
./regress.sh . global.tst 
34 unexpected PASS!
./regress.sh . 13x13.tst 
60 unexpected FAIL: Correct 'K5|L5', got 'H4'
./regress.sh . semeai.tst 
23 unexpected PASS!
30 unexpected PASS!
32 unexpected FAIL: Correct 'ALIVE_IN_SEKI ALIVE_IN_SEKI B6', got 'DEAD ALIVE 
PASS'
33 unexpected PASS!
34 unexpected PASS!
39 unexpected PASS!
41 unexpected FAIL: Correct 'ALIVE DEAD (PASS|B3|A6|B6|C5|D4|E3|E2|E1)', got 
'DEAD ALIVE PASS'
42 unexpected FAIL: Correct 'DEAD ALIVE PASS', got 'ALIVE DEAD C1'
./regress.sh . trevord.tst 
710 unexpected PASS!
./regress.sh . strategy4.tst 
190 unexpected PASS!
200 unexpected FAIL: Correct 'P6|P7|Q7|S18', got 'Q8'
./regress.sh . owl1.tst 
293 unexpected PASS!
./regress.sh . handtalk.tst 
20 unexpected FAIL: Correct 'N18', got 'P17'
./regress.sh . nngs3.tst 
310 unexpected PASS!
760 unexpected FAIL: Correct 'Q14', got 'P13'
./regress.sh . auto02.tst 
1 unexpected PASS!
./regress.sh . auto03.tst 
9 unexpected PASS!
./regress.sh . auto04.tst 
3 unexpected PASS!
./regress.sh . auto_handtalk.tst 
7 unexpected PASS!
8 unexpected FAIL: Correct 'ALIVE DEAD (N18|O17|S15)', got 'ALIVE_IN_SEKI 
ALIVE_IN_SEKI O18'
./regress.sh . ninestones.tst 
240 unexpected FAIL: Correct '!M19', got 'M19'
500 unexpected PASS!
540 unexpected FAIL: Correct 'B15', got 'L19'
560 unexpected PASS!
570 unexpected PASS!
590 unexpected PASS!
./regress.sh . tactics1.tst 
105 unexpected FAIL: Correct 'F7', got 'C9'
./regress.sh . manyfaces1.tst 
60 unexpected PASS!
./regress.sh . arend2.tst 
60 unexpected PASS!