[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnugo-devel] Patch for regression test
From: |
Gunnar Farneback |
Subject: |
Re: [gnugo-devel] Patch for regression test |
Date: |
Mon, 28 Jul 2003 18:22:23 +0200 |
User-agent: |
EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/20.7 (sparc-sun-solaris2.7) (with unibyte mode) |
SP Lee wrote:
> The following patch corrected an inappropriate test case.
Why do you consider it inappropriate?
> Index: nando.tst
> ===================================================================
> RCS file: /cvsroot/gnugo/gnugo/regression/nando.tst,v
> retrieving revision 1.15
> diff -u -r1.15 nando.tst
> --- nando.tst 10 Jul 2003 23:16:39 -0000 1.15
> +++ nando.tst 24 Jul 2003 21:09:01 -0000
> @@ -19,11 +19,13 @@
> #? [1 A12]
>
> #CATEGORY=CONNECTION
> -loadsgf games/nando/auto004.sgf
> -4 disconnect S7 S11
> -#? [1 S10|T9]*
> -5 same_dragon S7 S11
> -#? [0]*
> +#This is rather an attck problem
> +#gnugo 3.3.23 correctly answered the question "attack s12" with s10 /sp
> +#loadsgf games/nando/auto004.sgf
> +#4 disconnect S7 S11
> +##? [1 S10|T9]*
> +#5 same_dragon S7 S11
> +##? [0]*
Both these tests look perfectly good to me. The connection reading and
amalgamation needs to get this right, regardless whether the tactical
reading understands the situation.
/Gunnar