Re: [gnugo-devel] cosmic patch

[Stéphane Nicolet]

> The patch is not in the CVS. Let's get a correct patch
> before we add it.

What can I say ? I don't know how to get a more correct
patch than cosmic_5_1.2 using the diff command, and
cosmic_5_1.2 doesn't apply correctly.



> I think you are saying that these lines should be put back:
>
>     /* Increase strength if we're computing escape influence. */
>     if (q == &escape_influence && (pattern->class & CLASS_e))
>       add_influence_source(pos, this_color, 20 * source_strength, 1.6, 
> q);
>     else
>       add_influence_source(pos, this_color, source_strength, 1.6, q);
>
>     DEBUG(DEBUG_INFLUENCE,
>           "  low intensity influence source at %1m, strength %f, color %C\n",
>           pos, pattern->value, this_color);
>     return;

It's correct that this is the missing block. However, as I said,
it should be :

    /* Increase strength if we're computing escape influence. */
    if (q == &escape_influence && (pattern->class & CLASS_e))
      add_influence_source(pos, this_color, 20 * strength, attenuation, 
q);
    else
      add_influence_source(pos, this_color, strength, attenuation, q);

    DEBUG(DEBUG_INFLUENCE,
          "  low intensity influence source at %1m, strength %f, color %C\n",
          pos, strength, this_color);
    return;


> If I do that, I get error messages:
> influence.c: In function `influence_callback':
> influence.c:860: `source_strength' undeclared (first use in this 
> function)
> influence.c:860: (Each undeclared identifier is reported only once
> influence.c:860: for each function it appears in.)
> So there must be further problems with the patch.
> Dan

Thanks you very much for the time you spend on this, Dan...

Stephane





























... /// ... \\\ ...