[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnugo-devel] bug in find_neighbor_dragons()

From: Gunnar Farnebäck
Subject: [gnugo-devel] bug in find_neighbor_dragons()
Date: Mon, 26 Apr 2004 04:03:06 +0200
User-agent: EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/21.3 (sparc-sun-solaris2.9) MULE/5.0 (SAKAKI)

I've found that find_neighbor_dragons() has been broken for almost two
years, since my patch gunnar_3_3.8. The appended patch fixes the bug.
Interestingly fixing it results in three regression failures,

trevord:880     FAIL D6 [R7]
seki:111        FAIL C1 [C2]
seki:903        FAIL B1 [C2|C1]

The first one looks rather accidental and the last two are related to
semeai reading mistakes being uncovered. In my opinion there is no
question that we should fix the bug even though the regression delta
is disappointing, but I'll give you a chance to protest before
applying the patch.

- bugfix in find_neighbor_dragons


Index: engine/dragon.c
RCS file: /cvsroot/gnugo/gnugo/engine/dragon.c,v
retrieving revision 1.135
diff -u -r1.135 dragon.c
--- engine/dragon.c     23 Apr 2004 01:51:29 -0000      1.135
+++ engine/dragon.c     23 Apr 2004 21:14:00 -0000
@@ -862,9 +862,9 @@
-      if (!found_one)
-      break;
+    if (!found_one)
+      break;
   if (0) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]