Re: [Gnump3d-devel] searching by tag

[Steve Kemp]

On Sat, Nov 01, 2003 at 03:47:21PM -0600, Adam DiCarlo wrote:

> Here you go.
> 
> Bugfixes:
> 
>  - remove some references to /last/ (should be /recent/)

  Cool.

>  - searching by genre fixed

  Ooh.

>  - searching with no genre or search term specified gives an error
>    rather than all tracks

  That's a good thing to do.

>  - quieten gnump3d, unless DEBUG

  Yes I've been gradually removing a lot of tracing, one of the commits
 tonight removed a little more.

>  - minor install fix (ln -sf)

  This is going to be changed, there are issues with the way that the
 install works on Mac OS X, and *BSD.  (Most notably the lack of a
 root group).

> Enhancements:
> 
>  - searching by artist, album, song title or year

  That sounds great.

> Ok... I only messed with default/search.html.  I figured we should at
> least get consensus on the way I did it before rolling it all the way
> out.

  Yes that seems reasonable, thanks.

> Yeah. E.g., 'revise search' I guess.  That might take a little
> refactoring of the code somewhere down the line since if it sees terms
> it thinks it should do a search.

  Yes that is almost certainly true.

  Over time I'm becoming less happy with the current state of the code,
 there are too many asusmptions which may not remain valid and too
 much global state.

  Refactoring generally would be a good thing.

> Note this patch doesn't include previous patch.

  Patch?  This mail, nor the previous two arrived patch free, which is
 a shame as I was looking forward to seeing your changes.

Steve
---