Re: [GNUnet-developers] using $TMPDIR instead of /tmp

[Nils Gillmann]

Nils Gillmann transcribed 3.0K bytes:
> Schanzenbach, Martin transcribed 4.1K bytes:
> > Hey.
> > 
> > I don't thing the "//" should be an issue (albeit unnecessary).
> 
> Yes, you are right, I just tested it.
> 
> > Maybe the directory is not created?

Okay. I just grepped for "tmp" in the directory (src/transport) and it is
one of the testsuites where the path is hardcoded. Earlier in this thread
we talked about changing it, but I did not consider parts of the testsuite
which are written in C that use /tmp...

I have no time to fix it today.
I think it's okay that the testsuite crashes occasionally, so we should just
fix the hardcoded paths now.

> > BR
> > 
> > > On 7. May 2018, at 07:59, Nils Gillmann <address@hidden> wrote:
> > > 
> > > Nils Gillmann transcribed 1.8K bytes:
> > >> Christian Grothoff transcribed 3.9K bytes:
> > >>> On 05/06/2018 08:34 PM, Nils Gillmann wrote:
> > >>>> Christian Grothoff transcribed 2.9K bytes:
> > >>>>> On 05/05/2018 09:58 PM, Nils Gillmann wrote:
> > >>>>>> Anyways I just had some time to work on this, could you read
> > >>>>>> 5f627ce1a78f662d928fa6c73a90342d8bff5cf3 and tell me if I understood
> > >>>>>> the conversation we had here and your small commit right?
> > >>>>> 
> > >>>>> Yes, you got it perfectly right.
> > >>>>> 
> > >>>> 
> > >>>> I've changed the config files, now the problem for us in Nix and Guix
> > >>>> will be that the silly maximum unix path length will be hit quiet 
> > >>>> often...
> > >>>> at least for the Guix build chroot when the chroot is in 
> > >>>> /tmp/guix-build-gnunet-git1.drv-0/
> > >>>> 
> > >>>> The $GNUNET_TMP then gives you diretories like 
> > >>>> /tmp/guix-build-gnunet-git1.drv-0/gnunet/WAHTEVER-HERE/GOES/NOTHING
> > >>>> where previously they just landed in /tmp iirc.
> > >>>> 
> > >>>> We should make it possible to set the value of GNUNET_TMP before make 
> > >>>> check,
> > >>>> for example via the equivalent of export GNUNET_TMP="/tmp"; make check.
> > >>>> 
> > >>>> It's quiet unfortunate with the length..
> > >>> 
> > >>> Have you considered re-defining the maximum path length? Given that you
> > >>> are a distro, you should be able to recompile everything necessary
> > >>> (kernel, libc) with simply a larger value, right?
> > >> 
> > >> This time it wasn't the path length. We need to fix some parts of the
> > >> test suite to adopt to the new (dynamic) locations of the test folders.
> > >> 
> > >> I knew this, but I was preoccupied.
> > >> 
> > >> I can't do anything today, feel free to revert 
> > >> 9fbda6db66bf8dc074de6c8792f369801e4e5999
> > >> or fix the test suites that are affected. I myself can think of fixes 
> > >> tomorrow afternoon/evening.
> > >> For now the testsuite is broken with this.
> > > 
> > > One fixed, a couple more to go.
> > > 
> > > 
> > > FAIL: test_plugin_unix
> > > ======================
> > > 
> > > May 07 05:37:28-321787 test-plugin-transport-25451 ERROR Could not copy 
> > > hostkey `test_plugin_hostkey.ecc' to destination 
> > > `/tmp/guix-build-gnunet-git1.drv-0/gnunet//test-gnunetd-plugin-transport//.local/share/gnunet//private_key.ecc'.
> > >   Exiting.
> > > FAIL test_plugin_unix (exit status: 1)
> > > 
> > > 
> > > ^ should it be $GNUNET_TMP/foo or ${GNUNET_TMP}foo ? The two forward 
> > > slashes are irritating.
> > > 
> > >> _______________________________________________
> > >> GNUnet-developers mailing list
> > >> address@hidden
> > >> https://lists.gnu.org/mailman/listinfo/gnunet-developers
> > > 
> > > _______________________________________________
> > > GNUnet-developers mailing list
> > > address@hidden
> > > https://lists.gnu.org/mailman/listinfo/gnunet-developers
> > 
> 
>