gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] r13104 - gnunet/src/transport


From: gnunet
Subject: [GNUnet-SVN] r13104 - gnunet/src/transport
Date: Thu, 30 Sep 2010 21:55:00 +0200

Author: amatus
Date: 2010-09-30 21:55:00 +0200 (Thu, 30 Sep 2010)
New Revision: 13104

Modified:
   gnunet/src/transport/transport_api.c
Log:
The NULL test clearly needs to be before any dereferences.


Modified: gnunet/src/transport/transport_api.c
===================================================================
--- gnunet/src/transport/transport_api.c        2010-09-30 19:43:47 UTC (rev 
13103)
+++ gnunet/src/transport/transport_api.c        2010-09-30 19:55:00 UTC (rev 
13104)
@@ -1810,6 +1810,13 @@
       n = neighbour_add (handle, target);
 
     }
+  if (n == NULL)
+    {
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Could not create neighbour entry for peer `%s'\n",
+                 GNUNET_i2s (target));
+      return NULL;
+    }
 
   /**
    *  Send a request connect message if not connected,
@@ -1821,13 +1828,6 @@
       send_request_connect_message(handle, n);
     }
 
-  if (n == NULL)
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                 "Could not create neighbour entry for peer `%s'\n",
-                 GNUNET_i2s (target));
-      return NULL;
-    }
   switch (n->transmit_stage)
     {
     case TS_NEW:




reply via email to

[Prev in Thread] Current Thread [Next in Thread]