[GNUnet-SVN] r27268 - gnunet/src/transport

[gnunet]

Author: wachs
Date: 2013-05-23 14:37:23 +0200 (Thu, 23 May 2013)
New Revision: 27268

Modified:
   gnunet/src/transport/gnunet-service-transport_validation.c
Log:
remove warn message and add documentation


Modified: gnunet/src/transport/gnunet-service-transport_validation.c
===================================================================
--- gnunet/src/transport/gnunet-service-transport_validation.c  2013-05-23 
12:22:08 UTC (rev 27267)
+++ gnunet/src/transport/gnunet-service-transport_validation.c  2013-05-23 
12:37:23 UTC (rev 27268)
@@ -1208,23 +1208,24 @@
   do_verify = GNUNET_YES;
   if (0 != 
GNUNET_TIME_absolute_get_remaining(ve->pong_sig_valid_until).rel_value)
   {
+               /* We have a cached and valid signature for this peer,
+                * try to compare instead of verify */
                if (0 == memcmp (&ve->pong_sig_cache, &pong->signature, sizeof 
(struct GNUNET_CRYPTO_EccSignature)))
                {
+                       /* signatures are identical, we can skip verification */
                        sig_res = GNUNET_OK;
                        do_verify = GNUNET_NO;
                }
                else
                {
                        sig_res = GNUNET_SYSERR;
-        GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-               "Failed to check with cached signature: different signature on 
address %s:%s from peer `%s'\n",
-               tname, GST_plugins_a2s (ve->address),
-               GNUNET_i2s (sender));
+                       /* signatures do not match, we have to verify */
                }
   }
 
   if (GNUNET_YES == do_verify)
   {
+                       /* Do expensive verification */
                sig_res = GNUNET_CRYPTO_ecc_verify 
(GNUNET_SIGNATURE_PURPOSE_TRANSPORT_PONG_OWN,
                                 &pong->purpose, &pong->signature,
                                 &ve->public_key);