[GNUnet-SVN] r34690 - gnunet/src/set

[gnunet]

Author: grothoff
Date: 2014-12-19 14:33:26 +0100 (Fri, 19 Dec 2014)
New Revision: 34690

Modified:
   gnunet/src/set/gnunet-service-set.c
Log:
-fix use after free

Modified: gnunet/src/set/gnunet-service-set.c
===================================================================
--- gnunet/src/set/gnunet-service-set.c 2014-12-19 10:15:01 UTC (rev 34689)
+++ gnunet/src/set/gnunet-service-set.c 2014-12-19 13:33:26 UTC (rev 34690)
@@ -469,6 +469,8 @@
 static void
 incoming_destroy (struct Operation *incoming)
 {
+  struct GNUNET_CADET_Channel *channel;
+
   GNUNET_assert (GNUNET_YES == incoming->is_incoming);
   GNUNET_CONTAINER_DLL_remove (incoming_head,
                                incoming_tail,
@@ -490,10 +492,10 @@
     GNUNET_MQ_destroy (incoming->mq);
     incoming->mq = NULL;
   }
-  if (NULL != incoming->channel)
+  if (NULL != (channel = incoming->channel))
   {
-    GNUNET_CADET_channel_destroy (incoming->channel);
     incoming->channel = NULL;
+    GNUNET_CADET_channel_destroy (channel);
   }
 }