gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] r36015 - gnunet/src/transport


From: gnunet
Subject: [GNUnet-SVN] r36015 - gnunet/src/transport
Date: Sun, 28 Jun 2015 01:21:04 +0200

Author: amatus
Date: 2015-06-28 01:21:04 +0200 (Sun, 28 Jun 2015)
New Revision: 36015

Modified:
   gnunet/src/transport/gnunet-service-transport_neighbours.c
Log:
Change NPE into GNUNET_break (0)

See issue #3693


Modified: gnunet/src/transport/gnunet-service-transport_neighbours.c
===================================================================
--- gnunet/src/transport/gnunet-service-transport_neighbours.c  2015-06-27 
20:19:25 UTC (rev 36014)
+++ gnunet/src/transport/gnunet-service-transport_neighbours.c  2015-06-27 
23:21:04 UTC (rev 36015)
@@ -3554,6 +3554,18 @@
                          GNUNET_TRANSPORT_PS_CONNECTED,
                          GNUNET_TIME_relative_to_absolute 
(GNUNET_CONSTANTS_IDLE_CONNECTION_TIMEOUT));
 
+  if (NULL == n->primary_address.address) {
+    /* See issue #3693.
+     * We are in state = PSY_SYN_RECV_ACK or ack_state = ACK_SEND_ACK, which
+     * really means we did try (and succeed) to send a SYN and are waiting for
+     * an ACK.
+     * That suggests that the primary_address used to be non-NULL, but maybe it
+     * got reset to NULL without the state being changed appropriately?
+     */
+    GNUNET_break (0);
+    return GNUNET_OK;
+  }
+
   /* Reset backoff for primary address */
   GST_ats_block_reset (n->primary_address.address,
                        n->primary_address.session);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]