[GNUnet-SVN] [taler-exchange] branch master updated (1f02fc8 -> 928714d)

[gnunet]

This is an automated email from the git hooks/post-receive script.

marcello pushed a change to branch master
in repository exchange.

    from 1f02fc8  polish test helpers
     new ae25137  polish test loop
     new b427b51  polish bank history CMD
     new 928714d  Finish addressing #5332

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/bank-lib/testing_api_cmd_history.c | 6 ++++--
 src/bank-lib/testing_api_helpers.c     | 2 +-
 src/exchange-lib/testing_api_loop.c    | 8 +++++---
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/bank-lib/testing_api_cmd_history.c 
b/src/bank-lib/testing_api_cmd_history.c
index 361315e..9482361 100644
--- a/src/bank-lib/testing_api_cmd_history.c
+++ b/src/bank-lib/testing_api_cmd_history.c
@@ -595,8 +595,10 @@ check_result (struct TALER_TESTING_Interpreter *is,
 
 /**
  * This callback will (1) check that the HTTP response code
- * is acceptable and (2) that the history is consistent (FIXME,
- * say more about 'consistent').
+ * is acceptable and (2) that the history is consistent.  The
+ * consistency is checked by going through all the past CMDs,
+ * reconstructing then the expected history as of those, and
+ * finally check it against what the bank returned.
  *
  * @param cls closure.
  * @param http_status HTTP response code, #MHD_HTTP_OK (200)
diff --git a/src/bank-lib/testing_api_helpers.c 
b/src/bank-lib/testing_api_helpers.c
index 9ed041c..f61f666 100644
--- a/src/bank-lib/testing_api_helpers.c
+++ b/src/bank-lib/testing_api_helpers.c
@@ -225,7 +225,7 @@ TALER_TESTING_prepare_bank (const char *config_filename)
        "taler-bank-manage",
        "taler-bank-manage",
        "-c", "bank.conf",
-       "--with-db", database, /*FIXME: no hardcoded*/
+       "--with-db", database,
        "django",
        "flush",
        "--no-input", NULL)))
diff --git a/src/exchange-lib/testing_api_loop.c 
b/src/exchange-lib/testing_api_loop.c
index e9197da..fa7a427 100644
--- a/src/exchange-lib/testing_api_loop.c
+++ b/src/exchange-lib/testing_api_loop.c
@@ -202,7 +202,6 @@ TALER_TESTING_interpreter_fail
 {
   struct TALER_TESTING_Command *cmd = &is->commands[is->ip];
 
-  // FIXME: disconnect from the exchange.
   GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
               "Failed at command `%s'\n",
               cmd->label);
@@ -434,8 +433,11 @@ TALER_TESTING_wait_for_sigchld
 
 
 /**
- * Run the testsuite.  FIXME: explain why the commands are
- * copied into the state.
+ * Run the testsuite.  Note, CMDs are copied into
+ * the interpreter state because they are _usually_
+ * defined into the "run" method that returns after
+ * having scheduled the test interpreter.
+ *
  *
  * @param is the interpreter state
  * @param commands the list of command to execute

-- 
To stop receiving notification emails like this one, please contact
address@hidden