[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSMenu.m
From: |
Fred Kiefer |
Subject: |
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSMenu.m |
Date: |
Sat, 25 Jun 2005 13:20:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050414 |
Adam Fedor wrote:
>> From: Fred Kiefer [mailto:address@hidden
>>
>>
>> The code for the later change now implicitly sets the menu windows
>> frame to the stored one (or a scaled version of that, when the
>> screen has a different size), this could cause a problem if the
>> menu window would be resizable, as then some menu entries might
>> become unreachable (either because the screen is smaller or because
>> we have new entries in the menu). At the moment this isn't a
>> problem as menu windows don't allow resizing, but it is a hidden
>> dependency, which may break later on. Any idea, if and what we
>> should do here?
>>
>
> What about when the developer changes the menu around in a new
> version of the app? Does that pose the same problem? Probably we
> should just set the origin.
Also no problem as long as we have the menu marked as non-resizable.
>
>> The other change also has a slight problem. The visible frame of
>> the screen excludes a possible top menu and, if we ever have this,
>> we must of course position the menu there. Again currently this is
>> a no issue, I just wanted to state all these potential problems on
>> the mailing list, so that somebody will be able to dig them up
>> again, when this ever becomes an issue.
>>
>
> Yep. Maybe some comments in the code would help with future changes.
>
I add them, when I get arround to code again.
Fred