[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnustep-cvs] r23384 - in /libs/gui/trunk: ChangeLog Source/GSStanda
From: |
Gregory John Casamento |
Subject: |
Re: [Gnustep-cvs] r23384 - in /libs/gui/trunk: ChangeLog Source/GSStandardWindowDecorationView.m Source/NSControl.m Source/NSWindow.m |
Date: |
Mon, 4 Sep 2006 11:12:15 -0700 (PDT) |
All,
I have created the following branch for the mouseDown: fix:
svn+ssh://svn.gna.org/svn/gnustep/libs/gui/branches/NSControl_mouseDown_fix
If you would like to test this fix, please use the "svn switch" command to
switch to this branch and test it.
Thanks, GJC
--Gregory John Casamento
----- Original Message ----
From: Gregory John Casamento <address@hidden>
To: Gregory John Casamento <address@hidden>; Quentin Mathé <address@hidden>;
GNUStep Developers <address@hidden>
Cc: Riccardo Mottola <address@hidden>
Sent: Monday, September 4, 2006 11:03:04 AM
Subject: Re: [Gnustep-cvs] r23384 - in /libs/gui/trunk: ChangeLog
Source/GSStandardWindowDecorationView.m Source/NSControl.m Source/NSWindow.m
Quentin,
All of this being said... I do understand the change and why it's necessary. I
would like the change to go in, but not until it works properly and doesn't
cause applications to crash.
It's entirely possible that the the change has uncovered a latent problem
someplace else.
Later, GJC
--Gregory John Casamento
----- Original Message ----
From: Gregory John Casamento <address@hidden>
To: Quentin Mathé <address@hidden>; GNUStep Developers <address@hidden>
Sent: Monday, September 4, 2006 10:53:28 AM
Subject: Re: [Gnustep-cvs] r23384 - in /libs/gui/trunk: ChangeLog
Source/GSStandardWindowDecorationView.m Source/NSControl.m Source/NSWindow.m
Quentin,
I reverted it again because I found more issues with crashes as did Riccardo
Motolla and Andy Ruder with a number of applications.
Since Fred made the change, Fred is going to need to determine why he can't see
the problem and what the fix is. I will continue to investigate, but I'm not
going to leave code in the repository that causes applications to crash. It's
one thing if it causes the code to misbehave, it's another when it causes every
application I use to crash.
If you would like to investigate it as well, then revert back to the version of
NSControl prior to my rollback and try to debug the issue. The applications
which fail for me are: Ink, Gorm, and TalkSoup (among others). I prefered
testing with Ink, since it's quite small and simple.
Later, GJC
--Gregory John Casamento
----- Original Message ----
From: Quentin Mathé <address@hidden>
To: GNUStep Developers <address@hidden>
Cc: Gregory John Casamento <address@hidden>
Sent: Monday, September 4, 2006 4:24:32 AM
Subject: Re: [Gnustep-cvs] r23384 - in /libs/gui/trunk: ChangeLog
Source/GSStandardWindowDecorationView.m Source/NSControl.m Source/NSWindow.m
Le 3 sept. 06 à 18:18, Gregory Casamento a écrit :
> Author: gcasa
> Date: Sun Sep 3 18:18:42 2006
> New Revision: 23384
>
> URL: http://svn.gna.org/viewcvs/gnustep?rev=23384&view=rev
> Log:
> Reverted previous change. Added comments in NSWindow.
>
> Modified:
> libs/gui/trunk/ChangeLog
> libs/gui/trunk/Source/GSStandardWindowDecorationView.m
> libs/gui/trunk/Source/NSControl.m
> libs/gui/trunk/Source/NSWindow.m
Hi Gregory,
Why did you revert NSControl change again, did you stumble on an
other issue with this change?
For the toolbar button, iirc I reimplemented the -mouseDown: method
because we cannot currently set an action to be sent on mouseDown
event. That's not as common as sending action on mouseUp though, but
it's useful. Just to let you know I'm quite interested to have this
change reapplied in some way :-)
Cheers,
Quentin.
--
Quentin Mathé
address@hidden
_______________________________________________
Gnustep-dev mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/gnustep-dev