[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
drawing artifacts...
From: |
Matt Rice |
Subject: |
drawing artifacts... |
Date: |
Thu, 28 Dec 2006 14:46:02 -0800 (PST) |
sorry this email has a ton of attachments...
while i'm fairly sure the attached patch isn't correct
it does get rid of any remaining artifacts caused by
cursor movement in NSTableView
but i have yet to see anywhere the code i modify
actually does anything, since by default table view
NSTextFieldCells don't draw their backround
(in between foo3 and 8 nothing seemed to happen... so
i didn't attach those)
you can see the progression of these artifacts,
and the before/after of my most recent patch committed
to back in the new/old.png's...
http://svn.gna.org/viewcvs/gnustep/libs/back/trunk/Source/x11/XGServerWindow.m?rev=24287&r1=24246&r2=24287
this was using back-art...
anyhow it'd be great to get rid of these artifacts
completely, but it seems better than it was...
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Index: Source/NSTableView.m
===================================================================
--- Source/NSTableView.m (revision 24288)
+++ Source/NSTableView.m (working copy)
@@ -3271,13 +3271,13 @@
// We really want the correct background color!
if ([_editedCell respondsToSelector: @selector(setBackgroundColor:)])
{
- [(NSTextFieldCell *)_editedCell setBackgroundColor: _backgroundColor];
+ [(NSTextFieldCell *)_editedCell setBackgroundColor: [NSColor
textBackgroundColor]];
}
else
{
- [t setBackgroundColor: _backgroundColor];
+ [t setBackgroundColor: [NSColor textBackgroundColor]];
}
-
+
// But of course the delegate can mess it up if it wants
[self _willDisplayCell: _editedCell
forTableColumn: tb
@@ -3299,7 +3299,8 @@
}
_textObject = [_editedCell setUpFieldEditorAttributes: t];
-
+ [_textObject setDrawsBackground:YES];
+
drawingRect = [self frameOfCellAtColumn: columnIndex row: rowIndex];
if (flag)
{
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- drawing artifacts...,
Matt Rice <=