On 2007-01-24 22:05:26 -0800 Nicola Pero
<address@hidden> wrote:
but my main problem with GNUstep.sh isn't actually technical at all,
its the very first thing potential developers are going to see, so
will be the first impression,
and imho gives the impression of being strange because it is uncommon
for a build system to depend on environment variables to function.
I looked at your patch and I understand what you're trying to do ...
it's good
stuff and it's good to have this discussion, but let me first insist
in claryfying something ... ;-)
The build system does not depend on GNUstep.sh at all. We spent years
working on removing that dependency, and it's no longer there! :-)
It's not advertised much yet, but it will be clearly advertised in the
release note
of the forthcoming gnustep-make release. GNUstep.sh is obsolete in
the default
setup.
You only need to set GNUSTEP_MAKEFILES and everything will work
(assuming you have your tools in your path, and libs in your linker
paths). This is all already implemented on trunk! :-)
Yes, but you still need to do something before running make, which is
what this patch is
mostly about.
You only need to set GNUSTEP_MAKEFILES. This is already on trunk!
Once that's clear, we can discuss the patch ;-)
I see two good ideas in the patch ...
1. I guess you are suggesting to put a makefile somewhere in the make
search path and
change all makefiles to include it so that you can compile without
even setting GNUSTEP_MAKEFILES. I like the idea of not having to set
any variable to compile,
but I also see a couple of obvious cons --
it would be more difficult
to switch between different gnustep-make installations (at the moment,
you can easily
switch by just changing GNUSTEP_MAKEFILES!),
Not really, the patch allows you to switch installations by setting
PKG_CONFIG_PATH
and specifying --with-pkgconfig-path to configure to tell it where to
put gnustep.pc.
The difference being instead of always having to configure it,
configuration is made to
be something only people who need that behaviour have to do.