Re: [Gnustep-cvs] r24792 - /libs/gui/trunk/Source/NSFontManager.m

[Fred Kiefer]

I just looked that up in the current Apple documentation and they no
longer call the delegate in this case. Instead they list changeFont: :-)

But this does not seem to be about sending this message to the delegate.
I am no longer sure, what the correct behaviour is and will therefore
leave your comment in. To me it looks like the delegate of the font
manager is indeed useless and could be removed.



Nicola Pero wrote:
> Sure ... remove my comment, but I'd suggest replacing it with some explanation
> of what/when the delegate is used. ;-)
> 
> It looks like the only thing that the delegate does is being asked 
> fontManager:willIncludeFont:
> 
> Btw, depending on taste, but myself I'd also suggest moving the NSFontPanel 
> method
> 
>   - (BOOL) _includeFont: (NSString*)fontName  delegate: (id)fmDelegate
> 
> and make it an NSFontManager method (then you can drop the delegate argument, 
> and then
> someone looking at NSFontManager and wondering where the delegate is used 
> would find the
> method).
> 
> Thanks!
> 
> PS: I still find it stupid that the delegate isn't notified about changeFont: 
> too.
> 
> 
> 
> -----Original Message-----
> From: Fred Kiefer <address@hidden>
> Sent: Wed, March 7, 2007 12:17 pm
> To: Nicola Pero <address@hidden>
> Cc: address@hidden
> Subject: Re: [Gnustep-cvs] r24792 - /libs/gui/trunk/Source/NSFontManager.m
> 
> Nicola Pero wrote:
>> Author: nicola
>> Date: Wed Mar  7 03:47:11 2007
>> New Revision: 24792
>>
>> URL: http://svn.gna.org/viewcvs/gnustep?rev=24792&view=rev
>> Log:
>> Added comments about puzzling [NSFontManager -delegate] which is never used 
>> anywhere.  Indented a few lines
>>
>> Modified:
>>     libs/gui/trunk/Source/NSFontManager.m
>>
> 
> Actually the delegate of the font manage gets used. It is in NSFontPanel
> reloadDefaultFontFamilies. I had to look up that bit, it was so long ago
> when I did implement this method so I only had very vague memories of it.
> 
> Will you remove/clean up your comment or should I do it?
>