[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnustep-cvs] r27810 - in /libs/gui/trunk: ChangeLog Source/NSImage.
Re: [Gnustep-cvs] r27810 - in /libs/gui/trunk: ChangeLog Source/NSImage.m Source/NSScrollView.m
Mon, 9 Feb 2009 21:56:21 +0100
Am 08.02.2009 um 13:07 schrieb Fred Kiefer:
Richard Frith-Macdonald wrote:
Date: Sun Feb 8 12:02:57 2009
New Revision: 27810
Use proxies for named images so that changes to images are
when you change themes.
could you please explain a bit the motivation behind this change?
only gives me warnings when compiling what is worse I don't understand
the reason for this code when inspecting it.
May I chime in here? While not being a GNUstep developer, I develop
software to make my living. From experience I learned that short, to
the point comments in the code help a lot to remember the intentions
behind not so obvious parts of the code (I remember being puzzled
over some code I wrote myself after looking at it several months
later). Especially if you're working in a team (there situations
where you simply can't tell if something was done because it must be
done that way or if somebody didn't know any better or was just lazy).
Well I am just shooting in the dark here (I even didn't look at the
code in question, maybe there even are some comments - in that case
never mind), but this is not meant as criticism but as a hint from
somebody who learned it the hard way.