Re: [PATCH] A NSNetService implementation using Avahi

[Niels Grewe]

On Fri, Mar 26, 2010 at 09:26:14AM +0100, Fred Kiefer wrote:
> I only had a short look at this patch and was a bit surprised to see how
> little these two implementations share. In a normal class cluster you
> would expect that most of the code is in the common super class and only
> the primitive methods get implemented separately. What was the reason
> for doing it differently here?

The "reason" (apart from general laziness) is that the Avahi-based
implementation started its life as a local out-of-tree workaround for
me. Of course that's not a good reason. I will move stuff up to
NSNetService where possible, though that will require shuffling around
the class layouts bit, because the avahi subclasses make use of
behaviours.

> Even the delegate handling methods are duplicated, with the mDNS ones
> having an additional tracing call.

I left the mDNS implementation mostly untouched (except where it was
retaining delegates…), the tracing calls where already there.

> PS: You seem to be using tabs to indent your code. Spaces (two of them
> actually) are prefered.

Okay. I guess just piping it through 'indent' won't be sufficient to get
it cleaned up? Do we have any coding-style documentation (apart from the
"GNU Coding Standards", obviously).

Thanks for having a look!


Niels

signature.asc
Description: Digital signature