[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnustep-cvs] r31213 - in /libs/gui/trunk: ChangeLog Source/NSMenuVi
Re: [Gnustep-cvs] r31213 - in /libs/gui/trunk: ChangeLog Source/NSMenuView.m Source/NSPopUpButtonCell.m
Tue, 19 Oct 2010 09:42:14 -0600
I apologize for letting this slide and not responding before. The changes I
made definitely resolved some specific problems that we were seeing, but
perhaps not solved in the best possible way. I certainly understand your point
about addressing any Windows-specific issues in the backend or in the theme if
possible. I just haven't had time to revisit the issue to see if there is a way
to do that. If you have reverted my original fix then I will no doubt have to
look into it again soon! ;-)
I'll see if I can come up with a better solution this time. Working with the
Windows integration is a challenge, particularly the way Windows has a habit of
generating callbacks into our code while we're in the middle of doing something
else, which I believe was one of the problems in this case.
On Oct 17, 2010, at 6:04 AM, Fred Kiefer wrote:
> I never got a reply on this mail. I will now undo this dubious change.
> If it was really required for the WinUX theme I hope that somebody will
> add a corresponding change into that theme. I really would have
> preferred to have some discussion on this subject.
> Am 12.09.2010 20:49, schrieb Fred Kiefer:
>> Am 31.08.2010 01:02, schrieb Doug Simons:
>>> Author: dpsimons
>>> Date: Tue Aug 31 01:02:21 2010
>>> New Revision: 31213
>>> URL: http://svn.gna.org/viewcvs/gnustep?rev=31213&view=rev
>>> fix problem of pulldown action not being called for correct cell, and being
>>> called twice on Windows
>> Hi Doug,
>> could you please explain the first part of this change? The code itself
>> looks to me horribly wrong but I am sure you had good reasons for it.
>> The change note says it was needed for Windows, but I cannot find any
>> special handling for this case in our Windows backend. This leads me to
>> the assumption that you needed this change to get the WinUX theme
>> working. If this is correct, wouldn't it be better to fix the theme
>> instead? Currently we have the basic idea that themes don't change any
>> behaviour they only result in a different appearance. If this isn't true
>> for the WinUX theme, and there may be good reasons for that, eg for a
>> better Windows integration, it is the obligation of the theme to keep
>> the results at least consistent.
>> Most likely the processCommand: method of that theme will need some
>> tweaking to work correctly in your case.
>> Could you please look into this and undo the change on gui?