Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m

[Gregory Casamento]

Fred,

I understand what you're saying, but I'm not sure what to do to
correct it.  I admit I had a feeling when I made this commit that
there must be a better way of doing this.  Something, perhaps, more
centralized is needed.    NSMenuView, as you suggested, does seem like
the right place.

After some research it looks like _executeItemAtIndex:removeSubmenu:
might be a good candidate for this to be located centrally.

Let me know what you think.

GC

On Mon, Jan 10, 2011 at 4:49 PM, Fred Kiefer <address@hidden> wrote:
> I really can see the point behind all the recent changes to better
> support in window menus. Still, I think we are currently doing it the
> wrong way and this commit seems to prove my point.
>
> Having every action that may be caused by an in window menu to handle
> the window closing is wrong. Very wrong, I think. If we need to close
> the menu before showing up any window started by the menu item, than
> this belongs into the code in NSMenuView. But before another hack gest
> submitted for this, could we start a discussion what is really needed
> and how this gets done best?
>
> Cheers
> Fred
>
> Am 10.01.2011 03:48, schrieb Gregory Casamento:
>> Author: gcasa
>> Date: Mon Jan 10 03:48:30 2011
>> New Revision: 31864
>>
>> URL: http://svn.gna.org/viewcvs/gnustep?rev=31864&view=rev
>> Log:
>> 2011-01-09 21:58-EST Gregory John Casamento <address@hidden>
>>
>>       * Source/NSSavePanel.m: (-_initWithoutGModel): added
>>       code near the and to close the current menu when in Win95
>>       mode.  If this doesn't happen the menu remains open
>>       and allows the user to drag the window around while the
>>       menu remains in it's old position.
>>
>> Modified:
>>     libs/gui/trunk/ChangeLog
>>     libs/gui/trunk/Source/NSSavePanel.m
>
>



-- 
Gregory Casamento - GNUstep Lead/Principal Consultant, OLC, Inc.
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell)