Re: NSImage _clearFileTypeCaches

[Fred Kiefer]

Thank you for spotting this. I just submitted your change.

Fred

On 10.01.2012 21:49, Philippe Roussel wrote:
> Hi,
>
> Isn't the following patch needed for the code in +imageFileTypes and
> friends to rebuild the arrays when needed ? Those methods compare the
> arrays' pointers with nil and I think RELEASE doesn't affect nil to its
> argument.
>
> Index: Source/NSImage.m
> ===================================================================
> --- Source/NSImage.m    (révision 34482)
> +++ Source/NSImage.m    (copie de travail)
> @@ -1812,10 +1812,10 @@
>
>   + (void) _clearFileTypeCaches: (NSNotification*)notif
>   {
> -  RELEASE(imageUnfilteredFileTypes);
> -  RELEASE(imageFileTypes);
> -  RELEASE(imageUnfilteredPasteboardTypes);
> -  RELEASE(imagePasteboardTypes);
> +  DESTROY(imageUnfilteredFileTypes);
> +  DESTROY(imageFileTypes);
> +  DESTROY(imageUnfilteredPasteboardTypes);
> +  DESTROY(imagePasteboardTypes);
>   }
>
>   + (void) _themeDidActivate: (NSNotification *)notif
>
> Philippe