Re: gnustep-gui build link dependency orders wrong

[Marcus Müller]

Hi Richard,

On 04.07.2013, at 12:07, Richard Frith-Macdonald <address@hidden> wrote:

> Thanks ... that's more serious ... a bug in the order in which include 
> directories are used in gnustep-make ... but it was really easy to find/fix 
> (unless I've made some stupid mistake).
> Please try updating gnustep-make from svn trunk, and see if it fixes it for 
> you (it looks correct when I tty it).

all is correct now for base and gui.

In back, the x11, cairo and gpbs subprojects still have a wrong include order:

Making all for subproject x11...
/usr/local/bin/clang33 context.c -c \
      -MMD -MP -Wall -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
-DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -pthread -pthread -fPIC -Wall -DGSWARN 
-DGSDIAGNOSE
 -Wno-import -g -O2 -I../../Headers -I../. -I/usr/local/include/cairo 
-I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 
-I/usr/local/include/libpng15 -D_THREAD_SAFE -I/usr/local/include/freetype2 
-I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 
-I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 
-I/usr/local/include/libpng15 -D_THREAD_SAFE -I/usr/local/include 
-I/usr/local/include -I. -I/root/GNUstep/Library/Headers 
-I/usr/local/jenkins/workspace/GNUstep_trunk/GNUSTEP_ROOT/Local/Library/Headers 
-I/usr/local/jenkins/workspace/GNUstep_trunk/GNUSTEP_ROOT/System/Library/Headers
 -I/usr/local/include \
       -o obj/x11.obj/context.c.o
[…]
Making all for subproject cairo...
/usr/local/bin/clang33 CairoContext.m -c \
      -MMD -MP -Wall -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
-DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
-fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -fobjc-nonfragile-abi 
-D_NONFRAGILE_ABI -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 
-fgnu-runtime -fconstant-string-class=NSConstantString -I../../Headers -I../. 
-I/usr/local/include/cairo -I/usr/local/include/glib-2.0 
-I/usr/local/include/pixman-1 -I/usr/local/include/libpng15 -D_THREAD_SAFE 
-I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/cairo 
-I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 
-I/usr/local/include/freetype2 -I/usr/local/include/libpng15 -D_THREAD_SAFE 
-I/usr/local/include -I/usr/local/include -I. -I/root/GNUstep/Library/Headers 
-I/usr/local/jenkins/workspace/GNUstep_trunk/GNUSTEP_ROOT/Local/Library/Headers 
-I/usr/local/jenkins/workspace/GNUstep_trunk/GNUSTEP_ROOT/System/Library/Headers
 -I/usr/local/include \
       -o obj/cairo.obj/CairoContext.m.o
[…]
Making all for tool gpbs...
/usr/local/bin/clang33 gpbs.m -c \
      -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 
-DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions 
-fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -fobjc-nonfragile-abi 
-D_NONFRAGILE_ABI -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 
-fgnu-runtime -Wall -fconstant-string-class=NSConstantString -I../Headers 
-I../Source/. -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 
-I/usr/local/include/pixman-1 -I/usr/local/include/libpng15 -D_THREAD_SAFE 
-I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/cairo 
-I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 
-I/usr/local/include/freetype2 -I/usr/local/include/libpng15 -D_THREAD_SAFE 
-I/usr/local/include -I/usr/local/include -I. -I/root/GNUstep/Library/Headers 
-I/usr/local/jenkins/workspace/GNUstep_trunk/GNUSTEP_ROOT/Local/Library/Headers 
-I/usr/local/jenkins/workspace/GNUstep_trunk/GNUSTEP_ROOT/System/Library/Headers
 -I/usr/local/include \
       -o obj/gpbs.obj/gpbs.m.o

[…]


I just checked the old build logs to make sure that it's always been this 
incorrect order all the time, not a regression that you recently introduced.


Cheers,

  Marcus

--
Marcus Müller  .  .  .  http://www.mulle-kybernetik.com/znek/