Re: common_ApplicationFolder icon

[Bertrand Dekoninck]

Hi Ivan, can you please commit the patch and the icon ? It may be a while before I can ;-)

Bertrand

2016-03-23 23:55 GMT+01:00 Ivan Vučica <address@hidden>:

Correct, please don't replace this variable for now. I don't believe there are guarantees that the first folder returned when you search with NSAllDomainsMask will be from the system domain, and the code depends on the parent folder being named System.

On Wed, Mar 23, 2016 at 7:57 PM, Bertrand Dekoninck <address@hidden> wrote:

Le 23/03/2016 17:10, Riccardo Mottola a écrit :

Hi,

Bertrand Dekoninck wrote:

    sysAppDir =
NSSearchPathForDirectoriesInDomains(NSApplicationDirectory,
      NSSystemDomainMask, YES);
+  appDirs = NSSearchPathForDirectoriesInDomains(NSApplicationDirectory,
+    NSAllDomainsMask, YES);

if you do this, won't appsDir always include also sysAppsDir ?

Of course, that's why I asked if we could get rid of sysAppDir. As Ivan says, it's used to find what is the System folder.
I've tried to replace sysAppDir by appDirs in this part of the code and didn't notice any error, with a brief test.
But it seems to me that those "hack" as it's called by Ivan should then be complexified to be done with only the real sysAppDir present in the appDirs array. Too much for my skills.

Bertrand

_______________________________________________
Gnustep-dev mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/gnustep-dev