[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnutls-dev] Re: constification patch
From: |
Simon Josefsson |
Subject: |
[gnutls-dev] Re: constification patch |
Date: |
Wed, 28 Dec 2005 10:28:58 +0100 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) |
"ZIGLIO, Frediano, VF-IT" <address@hidden> writes:
> This simple patch add some const definition. It also assure that global
> variables are really const.
I installed most of the patch.
The lib/minitasn1/ changes didn't look right, so I didn't install
them. First, 'inline' can't be used because libtasn1 is supposed to
be C89 portable. Also, isn't it possible to solve this without
creating new *_const functions? Moving typecasts into a special
function just hide the problems. I think warnings are better here
because then we know that there is a problem.
Thanks,
Simon