Re: On dropping -D_REENTRANT -D_THREAD_SAFE

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> So I think we are safe.  To make sure, I'll build the latest daily
> snapshot and build it on this machine now..

I built both 2.2.0 and 2.3.0 snapshot without problem.  There were no
differences in config.h due to this change.

There was, however, a problem with HUGE_VAL:

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../includes -I../includes -I../lgl 
-I../lgl -I../gl -I../gl -I./cfg  -pipe -I/tmp/jas//include -g -O2 -MT shared.o 
-MD -MP -MF .deps/shared.Tpo -c -o shared.o `test -f 'cfg/shared.c' || echo 
'./'`cfg/shared.c
cfg/shared.c: In function `store_single_arg':
cfg/shared.c:727: error: wrong type argument to unary plus
cfg/shared.c:727: error: wrong type argument to unary minus

The line reads:

                        if (double_val == +HUGE_VAL || double_val == -HUGE_VAL)

It seems HUGE_VAL expands (gcc -E) into __builtin_huge_val, but I can't
find its definition.  It is probably a symbol defined in some library.

Replacing HUGE_VAL with HUGE worked, but I'm not sure if that is a good
idea...

/Simon