Re: guile self-tests fail in v.2.5?

[Ludovic Courtès]

Hi Simon,

Please find attached a patch that fixes compilation on `master' (I
prefer to let you review it and apply it).

Simon Josefsson <address@hidden> writes:

> On the master trunk there has been some heavy internal changes recently,
> but no incompatible API changes as far as I understand, and now the
> guile self-tests fails:
>
> make[3]: Entering directory `/home/jas/src/gnutls/guile/tests'
> guile: uncaught throw to gnutls-error: (#<gnutls-error-enum The Diffie 
> Hellman prime sent by the server is not acceptable (not long enough).> 
> handshake)
> make[3]: *** [check-TESTS] Interrupt

This is `anonymous-auth.scm': `gnutls_handshake ()' returns
`GNUTLS_E_DH_PRIME_UNACCEPTABLE' (whose error message is displayed
above).

Adding debugging output (which involves uncommenting the
`set-log-level!' and `set-log-procedure!' calls at the top of the file)
shows that the error is returned past `auth_dh_common.c:289'.

I tried changing the size of the DH prime used on the server-side (the
parameter to `make-dh-parameters'), as well as the minimum acceptable DH
size on the client side (the `set-session-dh-prime-bits!' parameter)
with no success.

I vaguely remember seeing a change regarding the default DH prime size,
but I couldn't find it.  Any hint?  Which commit initially triggered the
failure?

Thanks in advance,
Ludovic.

>From 2ec3592cef768e1de579399d3f9bd725c7dabae7 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Ludovic=20Court=C3=A8s?= <address@hidden>
Date: Wed, 2 Jul 2008 16:18:41 +0200
Subject: [PATCH] Fix compilation of OpenCDK with included minitasn1.

* lib/opencdk/Makefile.am (INCLUDES): Rename to `AM_CPPFLAGS'.
  (AM_CPPFLAGS)[ENABLE_MINITASN1]: Add `lib/miniitasn1'.
---
 lib/opencdk/Makefile.am |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/lib/opencdk/Makefile.am b/lib/opencdk/Makefile.am
index 4dcfeaf..aed03f6 100644
--- a/lib/opencdk/Makefile.am
+++ b/lib/opencdk/Makefile.am
@@ -20,10 +20,14 @@
 # Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
 # MA 02110-1301, USA
 
-INCLUDES = -I$(top_srcdir)/lib \
+AM_CPPFLAGS = -I$(top_srcdir)/lib \
        -I$(top_srcdir)/includes -I$(top_builddir)/includes \
        -I$(top_srcdir)/lgl -I$(top_builddir)/lgl
 
+if ENABLE_MINITASN1
+AM_CPPFLAGS += -I$(top_srcdir)/lib/minitasn1
+endif
+
 noinst_LTLIBRARIES = libminiopencdk.la
 
 libminiopencdk_la_SOURCES = armor.c filters.h keydb.h main.c types.h   \
-- 
1.5.6.1