[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUES
From: |
Simon Josefsson |
Subject: |
Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST |
Date: |
Thu, 25 Sep 2008 11:45:13 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) |
"Nikos Mavrogiannopoulos" <address@hidden> writes:
> I don't like mallocs for short sized buffers I think it is better to
> use a fixed buffer that will have maximum size enough to hold data.
I agree. Some of the buffers in gnutls_constate.c and gnutls_mpi.c are
arbitrary sized though, but have natural upper limits. Maybe you could
re-apply your patch without using C99 but instead using some CPP define
that holds the largest possible value? The gnutls_mpi.c code could
probably use a cut-off, if users request a random mpi larger than, say,
16k bits, then use gnutls_secure_malloc.
Thanks,
/Simon
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, (continued)
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Sam Varshavchik, 2008/09/20
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Nikos Mavrogiannopoulos, 2008/09/21
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Sam Varshavchik, 2008/09/21
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Nikos Mavrogiannopoulos, 2008/09/21
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Sam Varshavchik, 2008/09/21
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Sam Varshavchik, 2008/09/22
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Nikos Mavrogiannopoulos, 2008/09/23
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Nikos Mavrogiannopoulos, 2008/09/23
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Simon Josefsson, 2008/09/25
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST, Nikos Mavrogiannopoulos, 2008/09/25
- Re: 2.5.7 gnutls_x509_privkey_generate() returns GNUTLS_E_INVALID_REQUEST,
Simon Josefsson <=