Re: GnuTLS 2.8.6

[Simon Josefsson]

Andreas Metzler <address@hidden> writes:

> On 2010-03-15 Simon Josefsson <address@hidden> wrote:
>> We are proud to announce a new stable GnuTLS release: Version 2.8.6.
> [...]
>
> This release includes this change:
>
> --------------------------------------
> From 7e610054fa98f9c0b1e6d722bd6b5dc7dad1a711 Mon Sep 17 00:00:00 2001
> From: Simon Josefsson <address@hidden>
> Date: Thu, 05 Nov 2009 13:12:16 +0000
> Subject: Make sure libgcrypt's dependency on libgpg-error is known.
>
> ---
> diff --git a/lib/m4/hooks.m4 b/lib/m4/hooks.m4
> index 2eb2b2a..dc2904a 100644
> --- a/lib/m4/hooks.m4
> +++ b/lib/m4/hooks.m4
> @@ -34,7 +34,7 @@ AC_DEFUN([LIBGNUTLS_HOOKS],
>    DLL_VERSION=`expr ${LT_CURRENT} - ${LT_AGE}`
>    AC_SUBST(DLL_VERSION)
>  
> -  AC_LIB_HAVE_LINKFLAGS(gcrypt,, [#include <gcrypt.h>],
> +  AC_LIB_HAVE_LINKFLAGS([gcrypt], [gpg-error], [#include <gcrypt.h>],
>      [enum gcry_cipher_algos i = GCRY_CIPHER_CAMELLIA128])
>    if test "$ac_cv_libgcrypt" != yes; then
>      AC_MSG_ERROR([[
> --
> cgit v0.8.2.1
> --------------------------------------
>
> What problem is trying to solve?

GnuTLS doesn't build on Solaris without that.

> Gnutls does not uses gpg-error functions, but ends up being linked
> against gpg-error even on architecures which do not require linkage
> against indirect dependencies.

Does that cause any problem?

> I thought a major selling point of AC_LIB_HAVE_LINKFLAGS was that it
> found indirect dependencies if necessary (by relying on libtool la
> files).

I think lib-link.m4 could be enhanced to test whether dependencies are
not needed, and avoid pulling them in if so.  It seems to be a wishlist
kind of bug though.

/Simon