Re: 3.0.0 executable stack in libgnutls

[Nikos Mavrogiannopoulos]

On 08/08/2011 07:52 PM, Andreas Metzler wrote:
> Hello,
> 
> with 3.0.0 libgnutls' stack is marked executable:
> ----------------
> address@hidden:~/SVN/gnutls28/trunk$ readelf -l 
> /usr/lib/libgnutls.so.26.14.12 | grep -E 'Type |GNU_STACK '
>   Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
>   GNU_STACK      0x000000 0x00000000 0x00000000 0x00000 0x00000 RW  0x4
> address@hidden:~/SVN/gnutls28/trunk$ readelf -l 
> /tmp/GNUTLS/gnutls-3.0.0/debian/tmp/usr/lib/i386-linux-gnu/libgnutls.so.28.0.0
>  | grep -E 'Type |GNU_STACK '
>   Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
>   GNU_STACK      0x000000 0x00000000 0x00000000 0x00000 0x00000 RWE 0x4
> ----------------
> Note the "E" in RWE. Afaict this is caused by
> ./lib/accelerated/intel/appro-aes-x86.o missing a GNU-stack section.
> (SID)address@hidden:/tmp/GNUTLS/gnutls-3.0.0$ readelf -S \
>      ./lib/accelerated/intel/appro-aes-x86.o | grep -i stack
> (SID)address@hidden:/tmp/GNUTLS/gnutls-3.0.0$ readelf -S \
>      ./lib/accelerated/intel/aes-x86.o | grep -i stack
>   [21] .note.GNU-stack   PROGBITS        00000000 001f19 000000 00      0   0 
>  1

Nice catch. Does the attached patch solve the issue?

regards,
Nikos

patch.txt
Description: Text document