[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devi
From: |
Stef Walter |
Subject: |
Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devices |
Date: |
Mon, 16 Apr 2012 18:43:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 2012-04-16 18:39, Nikos Mavrogiannopoulos wrote:
> On 04/16/2012 06:28 PM, Nikos Mavrogiannopoulos wrote:
>
>>> The patch adds that line so I guess that's the real meat of the
>>> suggested change.
>> There is also a change to avoid calling retrieve_pin_for_pinfile if
>> attempts is zero. I've currently included it but although it seems
>> sensible for a file read, it might break other callbacks. Does the
>> p11-kit file read callback fail if the attempt is not the first one?
>
> Ok I see that there exists the line
> if (pin_flags & P11_KIT_PIN_FLAGS_RETRY) return NULL;
> thus there is no reason for the check in attempts. I have modified the
> patch.
Ah yes. Ignore my comments about this in the other email. Looks like I
already fixed it to prevent an endless loop.
Cheers,
Stef
- LP#929108 support reading PIN from file when using PKCS#11 devices, Andreas Metzler, 2012/04/15
- Message not available
- Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devices, Stef Walter, 2012/04/16
- Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devices, Stef Walter, 2012/04/16
- Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devices, Nikos Mavrogiannopoulos, 2012/04/16
- Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devices, Stef Walter, 2012/04/16
- Re: Fwd: LP#929108 support reading PIN from file when using PKCS#11 devices, Nikos Mavrogiannopoulos, 2012/04/16